-
Notifications
You must be signed in to change notification settings - Fork 4k
release-25.2: sql/stats: handle range counts when skipping dropped enum hist buckets #155651
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
These assertions that the first histogram bucket has NumRange=0 are useful for catching bugs, but a liability in production environments. Even with malformed histograms, we should not be failing query execution. Only check these assertions in test builds. Informs: cockroachdb#154461 Release note (bug fix): Change assertions about histogram NumRange=0 to only be checked in test builds.
|
Thanks for opening a backport. Before merging, please confirm that it falls into one of the following categories (select one):
Add a brief release justification to the PR description explaining your selection. Also, confirm that the change does not break backward compatibility and complies with all aspects of the backport policy. All backports must be reviewed by the TL and EM for the owning area. |
|
It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR? 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
|
✅ PR #155651 is compliant with backport policy Confidence: high 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@yuzefovich reviewed 2 of 2 files at r1, all commit messages.
Reviewable status:complete! 0 of 0 LGTMs obtained (waiting on @michae2)
Backport 1/2 commits from #155035.
/cc @cockroachdb/release
opt/props: only check histogram NumRange=0 in test builds
These assertions that the first histogram bucket has NumRange=0 are
useful for catching bugs, but a liability in production
environments. Even with malformed histograms, we should not be failing
query execution. Only check these assertions in test builds.
Informs: #154461
Release note (bug fix): Change assertions about histogram NumRange=0 to
only be checked in test builds.
Release justification: low-risk fix for a critical support issue.